10 Comments
User's avatar
Jen Kramer's avatar

🐍 🐍 🐍 Lovely job! Code looks good and things seem to work well.

One thing I noticed in your code -- .container h1, h3

This means "for all H1 elements descended from a class of container AND ALL H3 elements, do the following." If that's what you meant, awesome! However, this is a frequent mistake in CSS. If you want the h1's in .container and the h3's in .container, then you should write the selector as:

.container h1, .container h3

Great work and thanks for sharing!

Expand full comment
Milan Mihajlovic's avatar

I didn't sure if I understand the task well but with instructions I got this result.

We could use rem just for h1, h2, h3.

For p, rem, don't have effect.

https://codepen.io/miklaan/pen/abwKGGR

Expand full comment
Jen Kramer's avatar

🐍 🐍 🐍 Yes! rem is fine for h1, h2, and h3. 1rem should be the default font size for p. It's possible something overrode that style later in the document. In any case, it looks great - nice work and thanks for sharing!

Expand full comment
Romola Chrzanowski's avatar

https://codepen.io/romola/pen/OJgZaRd?editors=1100

I think the vertical spacing exercise is important. It probably could have been achieved more simply than this. I didn't attempt the proximity challenge.

Expand full comment
Jen Kramer's avatar

🐍 🐍 🐍 Well done! Your color choices make the vertical spacing very clear to see. Thanks for sharing! 😁

Expand full comment
Jen Kramer's avatar

🐍 🐍 🐍 Lovely, lovely job with this! I hope working with all of those units was helpful for you. Thanks for sharing, as always!

Expand full comment
Jen Kramer's avatar

🐍 🐍 🐍 Looks great! Hope you found the exercise in working with units helpful - thanks for sharing!

Expand full comment